fix: usage of node12 which is deprecated in CI
#1659
Conversation
.github/workflows/docs-check.yml
Outdated
| @@ -14,18 +14,13 @@ jobs: | |||
| uses: actions/checkout@v3 | |||
|
|
|||
| - name: Install Python | |||
| uses: actions/setup-python@v1 | |||
| uses: actions/setup-python@v5 | |||
There was a problem hiding this comment.
v5 is the latest major version of actions/setup-python at the time of this writing.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| - name: Install Rust | ||
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: stable |
There was a problem hiding this comment.
is there a reason why this one is deleted as well?
There was a problem hiding this comment.
Yes, that action also uses node12 which is deprecated.
|
You're welcome! |
|
the install dependencies for node build seems to break from this 😓 |
hamirmahal
force-pushed
the
fix/usage-of-node12-which-is-deprecated-in-docs-check-actions
branch
from
84e8031 to
3e7f99b
Compare
|
It looks like hamirmahal@84e8031 fixes it. At the very least, that change passes with all checks in a fork. |
|
PR just merged to main fixed this! (it did all of the actions) 🤗 thanks for the contribution |
|
You're welcome! Feel free to close this if it's no longer necessary. |
|
Closing then! 🤗 |
hamirmahal
deleted the
fix/usage-of-node12-which-is-deprecated-in-docs-check-actions
branch
fixes #1658.