Handle None before gathering num items in batch across devices
#35399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunMarc
reviewed
Dec 23, 2024
src/transformers/trainer.py
Outdated
Comment on lines
5156
to
5158
| if num_items_in_batch is None: | ||
| num_items_in_batch = torch.tensor(0).to(self.args.device) | ||
|
|
There was a problem hiding this comment.
Let's do that only inside average_tokens_across_devices as num_items_in_batch should be an int. We need a tensor only for the gather
There was a problem hiding this comment.
Then can I assume it is okay for this function to return None for num_items_in_batch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #35387
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr