Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate RPC methods should not be final #286

Open
longquanzheng opened this issue Dec 20, 2024 · 0 comments
Open

Validate RPC methods should not be final #286

longquanzheng opened this issue Dec 20, 2024 · 0 comments
Labels

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Dec 20, 2024

Context
Otherwise byteBuddy won't work when intercepting the call.

All method in Java by default is not final, but for Kotlin, open must be added for the RPC method to make it not final.

See https://stackoverflow.com/questions/54043234/bytebuddy-method-interception-doesnt-work-in-kotlin

Goal
We should throw error when the rpcStub is created or workflow is registered (prefer former). Because when invoking later, there is not obivous errors for this issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant