Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer issues #73

Closed
superjai opened this issue Nov 15, 2024 · 3 comments
Closed

Footer issues #73

superjai opened this issue Nov 15, 2024 · 3 comments
Assignees

Comments

@superjai
Copy link
Contributor

  1. The footer should not appear on the About page
  2. In case of no content for a footer field - or in the worst case, all footer fields are blank - have the footer itself show up as blank, instead of the following:
    Screenshot 2024-11-14 at 4 37 02 PM
@MathewBiddle
Copy link
Contributor

@mwengren do you have an approximate timeline for our ioos.us header/footer templates to be available for projects like this to incorporate?

@superjai please keep an eye on the progress in ioos/ioos-us#263. For all ioos.us sites, we plan to release an insert-able header/footer to give a consistent look and feel to all of our sites. I'm not sure on the timeline, but I warn against spending too much time fixing header/footer issues as we will be providing updated guidance.

@mwengren
Copy link
Member

I'm gong to redirect the question about timeline for implementing the templates to @sarinamann-noaa.

I'll add though that I think it's possible for an ioos.us sub-site to have dual footers if preferred. In this case, the SanctuaryWatch footer could go above the site-wide ioos.us footer on the page. This might affect the SanctuaryWatch site design in terms of style, but that can be up to them to adjust as needed. All sites ioos.us sites will need to include the standard footer (and header), however.

I expect the header to be more difficult to integrate with sites that have their own site-specific header, FWIW, including presumably this site. This might require some styling changes to the ioos.us-wide header if it's determined it needs to be changed to be less prominent (smaller, lighter, ?).

cc @nguyandy

skanda-vasishta added a commit that referenced this issue Nov 21, 2024
@skanda-vasishta
Copy link
Contributor

errors fixed, see footer.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants