Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate version bump in ipget --version #113

Closed
lidel opened this issue Jun 24, 2022 · 0 comments · Fixed by #149
Closed

Automate version bump in ipget --version #113

lidel opened this issue Jun 24, 2022 · 0 comments · Fixed by #149
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours help wanted kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up
Milestone
Best Effort Track

Comments

@lidel
Copy link
Member

lidel commented Jun 24, 2022 •
edited
Loading

Version has to be bumped manually in three(!) places. .version.json should be the source of truth.

We should automate this, I just realized it has been causing a patch release for the second time 🙈

  1. chore: release v0.8.1 #108
  2. chore: release v0.9.0 #111 (comment) → Release v0.9.1 #112
@lidel lidel added help wanted dif/easy Someone with a little familiarity can pick up P1 High: Likely tackled by core team if no one steps up kind/maintenance Work required to avoid breaking changes or harm to project's status quo effort/hours Estimated to take one or several hours labels Jun 24, 2022
@ipfs ipfs deleted a comment from welcome bot Jun 24, 2022
@lidel lidel moved this to 🥞 Todo in IPFS Shipyard Team Jun 24, 2022
@lidel lidel added this to the Best Effort Track milestone Jun 24, 2022
@lidel lidel pinned this issue Jun 24, 2022
@lidel lidel mentioned this issue Jun 24, 2022
Merged
@aschmahmann aschmahmann mentioned this issue Oct 23, 2023
Closed
gammazero added a commit that referenced this issue Aug 14, 2024
@gammazero
App version is taken from version.json compiled in
082283e 
This ensures that the version is always set to the correct value. making version.json the source of truth.

Fixes #146
Fixes #113
This was referenced Aug 14, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours help wanted kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
IPFS Shipyard Team
Status: 🥞 Todo
Milestone
Best Effort Track
Development

Successfully merging a pull request may close this issue.

App version is taken from version.json compiled in ipfs/ipget
1 participant
@lidel