Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge with istanbul-lib-hook #9

Open
bcoe opened this issue Jun 28, 2016 · 1 comment
Open

merge with istanbul-lib-hook #9

bcoe opened this issue Jun 28, 2016 · 1 comment

Comments

@bcoe
Copy link
Member

bcoe commented Jun 28, 2016

istanbul-lib-hook, and append-transform have similar functionality; I think we should figure out how to merge the two.

istanbul-lib-hook has the added advantage that it handles hooking into the vm.createScript method:

https://github.com/istanbuljs/istanbul-lib-hook/blob/master/lib/hook.js#L109

I'd love to get this functionality added to nyc; @jamestalmage, @gotwarlost what do you think the best option is for this? Perhaps we could keep both libraries, with append-transform as a dependency in istanbul-lib-hook?

@gotwarlost
Copy link

@jamestalmage says it best here: #8 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants