Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetBrains MarketPlace Compatibility Warning for RandomStringUtils Usage #70

Closed
johnthagen opened this issue Jan 14, 2022 · 2 comments
Closed
Assignees

Comments

@johnthagen
Copy link
Owner

After the submission of 1.6.1 to the JetBrains MarketPlace the following compatibility report was submitted back.

Screenshot 2022-01-14 081333

Screenshot 2022-01-14 081215

IntelliJ IDEA Ultimate IU-192.7142.36 (2019.2.4)1 compatibility warning
1 compatibility warning
Plugin uses classes of Java plugin, for example
'RandomStringUtils' is used at 'CppcheckInspection.checkFile(...)'
but the plugin does not declare explicit dependency on the Java plugin, via <depends>com.intellij.modules.java</depends>.
Java functionality was extracted from the IntelliJ Platform to a separate plugin in IDEA 2019.2.
For more info refer to https://blog.jetbrains.com/platform/2019/06/java-functionality-extracted-as-a-plugin
Dependencies used
Dependencies of cppcheck 1.6.1 specified in plugin.xml are resolved with respect to IntelliJ IDEA Ultimate IU-192.7142.36 (2019.2.4). Java 11.0.4 was used for verification.

com.github.johnthagen.cppcheck 1.6.1
\--- com.intellij 192.7142.36 [declaring module com.intellij.modules.lang]

IntelliJ IDEA Ultimate IU-193.7288.26 (2019.3.5)1 compatibility warning
1 compatibility warning
Plugin uses classes of Java plugin, for example
'RandomStringUtils' is used at 'CppcheckInspection.checkFile(...)'
but the plugin does not declare explicit dependency on the Java plugin, via <depends>com.intellij.modules.java</depends>.
Java functionality was extracted from the IntelliJ Platform to a separate plugin in IDEA 2019.2.
For more info refer to https://blog.jetbrains.com/platform/2019/06/java-functionality-extracted-as-a-plugin
Dependencies used
Dependencies of cppcheck 1.6.1 specified in plugin.xml are resolved with respect to IntelliJ IDEA Ultimate IU-193.7288.26 (2019.3.5). Java 11.0.6 was used for verification.

com.github.johnthagen.cppcheck 1.6.1
\--- com.intellij 193.7288.26 [declaring module com.intellij.modules.lang]

This likely further motivates #69

@johnthagen
Copy link
Owner Author

@firewave As mentioned in #94, this is currently blocking upload of the latest release.

@firewave
Copy link
Collaborator

#95 adds the additional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants