Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

All: Deprecate portions of initSelector that are not "[data-ui-role='<widgetname>']" #7940

Closed
gabrielschulhof opened this issue Jan 26, 2015 · 5 comments
Closed

All: Deprecate portions of initSelector that are not "[data-ui-role='<widgetname>']" #7940

gabrielschulhof opened this issue Jan 26, 2015 · 5 comments
Assignees
@apsdehal
Labels
Status: Has PR
Milestone
1.5.0

Comments

@gabrielschulhof
Copy link

Place comments in the code of the form

// The default value of initSelector is DEPRECATED as of 1.5.0 and will be removed in 1.6.0

before each initSelector declaration.

Make sure that it is clear that initSelector itself is not deprecated and that it will continue to be honoured in future versions, only that it will be set to [data-ui-role="<widgetname>"] by default for all widgets.
@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Jan 26, 2015
@gabrielschulhof
Copy link
Author

See also jquery/api.jquerymobile.com#353

@gabrielschulhof
Copy link
Author

See also jquery/jquerymobile.com#113

@ray007
Copy link

ray007 commented May 22, 2015

I guess that means selectmenu will also get a less greedy initSelector?
Something like "select:not(:jqmData(role)), select:jqmData(role=selectmenu)"?

@arschmitz
Copy link
Contributor

@ray007 the init selector for selectmenu will be [data-ui-role='selectmenu'] after this change

@apsdehal
Copy link
Contributor

apsdehal commented May 8, 2016

@arschmitz I guess this can be closed now.

@apsdehal apsdehal closed this as completed Jun 6, 2016
@apsdehal apsdehal self-assigned this Aug 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@apsdehal apsdehal

Labels
Status: Has PR
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
4 participants
@ray007 @arschmitz @gabrielschulhof @apsdehal