Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Roles (guest / admin) to user accounts #26

Open
archienorman11 opened this issue Nov 8, 2019 · 4 comments
Open

Comments

@archienorman11
Copy link

No description provided.

@karec
Copy link
Owner

karec commented Nov 12, 2019

Hi @archienorman11,

While I'm okay to work on this, I'm not sure this fit the scope of this cookiecutter. This API is very simple and don't have any resource except for users, adding RBAC to it may be to opinionated and force users into a permission system that will not fit their need, I'm waiting for more feedback on this issue before starting coding this.

@archienorman11
Copy link
Author

Hey @karec.

I completely agree that this could be a little opinionated. My thoughts were that we have an admin user by default, so separate permissioned + un-permissioned roles would be useful.

@karec
Copy link
Owner

karec commented Jan 18, 2020

FYI, I just made a PR with some cleanup. After it get merged I'll work on that topic

@archienorman11
Copy link
Author

thanks @karec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants