-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate in favor of ffmpeg-static? #55
Comments
@kribblo Thoughts? |
@derhuerst FYI |
Not so many; I have only had a glance at that project, but if it does the same job equally good or better... in principle, I do not think it makes sense to have duplicate efforts (unless competing for a "best" way). This project was made with one purpose only, to download only one binary instead of all of them, which all other projects did. But it has its flaws for weirder cases and for updating. I wrote it for the purposes of my former company, but seemed useful enough to release publicly. Stars I could not care less about :) , but maintenance is good. And focusing in one place, so feel free to do this. For those who only use this for simple wav->ogg it will keep on working anyway, for those with greater needs it would be good. Forge ahead as you please. :) |
Hey, maintainer of I agree that it makes sense to "merge" the two projects, everything is just wasted effort. I also don't care about which way we do it.
Yeah, same for "Just" downloading a binary is more work than I originally thought, however; Over time, I have
Potential enhancements:
I'm currently maintaining |
I took a much more simplistic approach, using the built in os and architecture features of node + sub-project dependencies, then I've been downloading binaries from sources listed on the official page and put them in each project and then they just ended up on npmjs. It's been working well for at least the initial 5 variations, just a little bit of a chore to update now and then, the upload is semi-automated but not the update etc. Could be done. I'm unlikely to maintain or be involved since I do not personally use it anymore and gradually lost interest. As such, I do not personally mind which of the approaches you guys want to go with, I guess discuss among the active people of both projects and just go with one? |
Also, not totally convinced a cross-compile pipeline is worth the effort to maintain, I guess there's a reason that doesn't already exist out there. Not that I'd stop anyone, but that can be hard work. As long as there are sources trusted by the project i think you should consider leaving it at that, but it's just advice, based on well, knowing how much effort those things can take to keep up :) |
Yeah I solved it the same way first, but I didn't like several factors:
|
Matter of taste, I guess.
With all that said, probably best if those who are going to work with it most and actively pick what they are comfortable with working with :) |
As part of becoming a contributor of this package I have looked around for alternatives to see whether it makes sense to continue maintenance of node-ffmpeg-installer. It seems as though https://github.com/eugeneware/ffmpeg-static fulfills the same purpose, already has the means to automatically keep the binaries updated, has more GitHub stars and is actively maintained.
It seems to me that this would be the best course of action.
The text was updated successfully, but these errors were encountered: