Set experiment names at a max of 40 characters. #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en(experiment-name) > 63, then the suggestion service cannot start. Signed-off-by: Aydan Pirani <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/rerun-all |
Comment on lines
+88
to
+89
| " (e.g. 'my-name', or 'abc-123', regex used for validation is '^[a-z]([-a-z0-9]*[a-z0-9])?)'" + | ||
| " and may not be larger than 40 characters. " |
There was a problem hiding this comment.
Suggested change
| " (e.g. 'my-name', or 'abc-123', regex used for validation is '^[a-z]([-a-z0-9]*[a-z0-9])?)'" + | |
| " and may not be larger than 40 characters. " | |
| " (e.g. 'my-name', or 'abc-123', regex used for validation is '^[a-z]([-a-z0-9]*[a-z0-9])?)')," + | |
| " and may not be longer than 40 characters. " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As of now, the suggestion service does not start if the concatenation of algorithm and experiment name are more than 63 characters. The experiment gets created successfully on the dashboard, but never runs. This PR directly rejects all experiments with names longer than 40 characters.
Which issue(s) this PR fixes:
Fixes #2454
Checklist:
Previous Behavior:
Would successfully allow the experiment to be submitted, and would also create the experiment. However, the suggestion service would crash silently with no error output.
New Behavior:
Throws the following error message: