-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ecr-credential-provider
binary to release assets
#568
Add ecr-credential-provider
binary to release assets
#568
Conversation
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @gregfurman. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
efefd70
to
3baf235
Compare
We will most likely remove the automated release creation. The asset can be uploaded as part of the release procedure post pushing to staging (thus ensuring that the uploaded asset also match the asset in the prod bucket). |
/hold |
Any reason not to push the binary for now until a final decision / approach is made? The lack of available binary combined with the ECR credential helper being the officially documented kubernetes example is confusing a lot of people if you look on the official slack. |
The decision has been made, just not implemented. What needs to happen is the artifact promotion job needs to be fixed. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For the tag: the you can see the other versions/binaries using the gcp console: |
Seems like this can be closed, @gregfurman @olemarkus do you disagree? |
@dims Is that actually the process? It doesn't seem some of the 1.28 releases are in that GCS bucket. |
I think we've missed artifact promotion for the last round of releases. I'll get a PR open. The container images are live, though. |
Did you open a PR for artifact promotion @cartermckinnon? I only found this after 10 mins of searching on this repo. |
Yet another example of how the documentation for this provider is severely lacking and really needs to be prioritized for update and cleanup. |
@et304383 awesome thanks for volunteering! |
No, this is AWS' job. They (you) are a multi-billion dollar company that provides this essential provider with little to no documentation or instructions. That is not in line with the quality we have come to expect from AWS. |
Apologies! my bad, please note the this is a kubernetes community repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR updates the project's Github actions in order to build the
ecr-credentials-provider
binary and add it to new release assets.This means that users will no longer be required to to compile and distribute the binary themselves. Moreover, Go, Git, or a Go Docker image does not need to be present on the host system in order to compile the binary
Which issue(s) this PR fixes:
Fixes #512
Does this PR introduce a user-facing change?:
NONE