Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Support blocklist reposting #3670

Open
4 tasks
jessopb opened this issue Sep 20, 2022 · 5 comments · May be fixed by #3677
Open
4 tasks

Better Support blocklist reposting #3670

jessopb opened this issue Sep 20, 2022 · 5 comments · May be fixed by #3677
Assignees
@eukreign

Comments

@jessopb
Copy link
Member

jessopb commented Sep 20, 2022 •
edited
Loading

We propose the general principle that
claim_list should always be able to show you your claims and their references in entirety (with exception of sd hash)
resolve if blocked returns the error, respecting the block list.
claim_search filters out blocked claims.

Currently, it seems claim_list with --resolve does not resolve reposted claims.
Currently, we cannot look up a particular blocked item or channel with a blocked item in the event of a dispute/unblock.

  • claim_list --resolve includes reposted claims (except sd hash)(even if blocked) and their signing channels
  • claim_list --reposted_claim_id --resolve (implied?) returns a repost of the claim_id
  • claim_list --reposted_channel_id returns all reposts for claims in the channel.
  • claim_list output for reposts should have claim_id rather than claim_hash bytes (edit: rather? or both? - Jeremy).
@kauffj
Copy link
Member

kauffj commented Sep 26, 2022

@eukreign this ought to be a priority after current work is complete. Please discuss with @jessopb and/or bring up on next stand up if there are questions here.

@jessopb
Copy link
Member Author

jessopb commented Sep 26, 2022 •
edited
Loading

Does it make sense to resolve and then if necessary, do the blockchain lookup and filter out the sdhash if resolved returned blocking error?

@eukreign
Copy link
Member

@kauffj I would need more info on how this would work. Currently claim_list --resolve simply calls resolve in the background to provide the claim list with extra resolved metadata. If a claim is blocked from being resolved then claim_list --resolve couldn't resolve it just as plain resolve can't resolve it.

@jessopb
Copy link
Member Author

jessopb commented Sep 26, 2022

Use lbry.wallet.Network.get_claim.by_id for the repost,
Then/and resolve the url to know if you should filter.

@jessopb
Copy link
Member Author

jessopb commented Sep 27, 2022

#3676 made an issue for fourth bullet point.

@eukreign eukreign linked a pull request Oct 3, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eukreign eukreign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

claim_list shows metadata of blocked claims lbryio/lbry-sdk
3 participants
@eukreign @kauffj @jessopb