[HandshakeToDC] Missing cf conversions and memory stuff

[teqdruid]

HandshakeToHW also lowers the arith and malloc dialects. This is missing from the DC flow. It should probably get pulled out into a separate pass.

[teqdruid]

For arith, I just found the map-arith-to-comb pass.

[mortbopet]

For arith, I just found the map-arith-to-comb pass.

Usage of this should be orthogonal to HandshakeToDC. I think the best thing to do here is to have a default fallback lowering of non-"special" operations in HandshakeToDC which inserts a join for it's operand (i.e. a unit rate actor. HandshakeToHW does this extremely poorly since it was written before map-arith-to-comb... hence it essentially custom-implements map-arith-to-comb.

Unsure what you mean with malloc dialect; are you referring to the handshake memory operations?

[teqdruid]

Sorry... by "malloc", I meant "memref".

…

On Mon, Nov 25, 2024, 3:59 AM Morten Borup Petersen < ***@***.***> wrote: For arith, I just found the map-arith-to-comb pass. Usage of this should be orthogonal to HandshakeToDC. I think the best thing to do here is to have a default fallback lowering of non-"special" operations in HandshakeToDC which inserts a join for it's operand (i.e. a unit rate actor <https://github.com/llvm/circt/blob/87d10b7582247e3e0e78052e080e17871d81c2ce/lib/Conversion/HandshakeToHW/HandshakeToHW.cpp#L1114>. HandshakeToHW does this extremely poorly <https://github.com/llvm/circt/blob/87d10b7582247e3e0e78052e080e17871d81c2ce/lib/Conversion/HandshakeToHW/HandshakeToHW.cpp#L1922-L1935> since it was written before map-arith-to-comb... hence it essentially custom-implements map-arith-to-comb. Unsure what you mean with malloc dialect; are you referring to the handshake memory operations? <https://circt.llvm.org/docs/Dialects/Handshake/#handshakememory-circthandshakememoryop> — Reply to this email directly, view it on GitHub <#7826 (comment)> or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALNXYB7LJRVVGB6HOKBWYT2CLRIHBFKMF2HI4TJMJ2XIZLTSSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI3TONJUGY2TGNJSGOSG4YLNMWUWQYLTL5WGCYTFNSWHG5LCNJSWG5C7OR4XAZNMJFZXG5LFINXW23LFNZ2KM5DPOBUWG44TQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJSGQ2TANZSGUYTJAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDENRWGM2TCMBRHE4YFJDUPFYGLJLMMFRGK3FFOZQWY5LFVI3TONJUGY2TGNJSGOTXI4TJM5TWK4VGMNZGKYLUMU> . You are receiving this email because you authored the thread. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> .