Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StdInitializerListOp next steps #1215

Open
HerrCai0907 opened this issue Dec 7, 2024 · 0 comments
Open

StdInitializerListOp next steps #1215

HerrCai0907 opened this issue Dec 7, 2024 · 0 comments

Comments

@HerrCai0907
Copy link
Contributor

HerrCai0907 commented Dec 7, 2024

I was giving this more thought, and I think we should take a step back:

  • We should revert the PR that introduced cir.std.initializer_list.
  • Introduce a new PR where cir.std.initializer_list is just a thin layer over the initialization work, for example:
%0 = cir.alloca INITLIST_TYPE, !cir.ptr<INITLIST_TYPE>
cir.std.initializer_list {
  %1 = cir.const #cir.int<1>
  ... // all init work goes here
}

My rationale is that we don't yet have a pass taking advantage of this and we should probably use that to guide how we really want to design this, anything before that will be more or less a guess game. Once we have usage going through it and we start writing a pass that wants to look at the initialization data, then we refine. Sorry for the churn, WDYT?

Originally posted by @bcardosolopes in #1184 (comment)

smeenai pushed a commit that referenced this issue Dec 7, 2024
Revert "[CIR][Dialect] Introduce StdInitializerListOp to represent
high-level semantics of C++ initializer list (#1121)".

This reverts commit 7532e05.

First step for #1215.
@bcardosolopes bcardosolopes changed the title @HerrCai0907 I was giving this more thought, and I think we should take a step back: StdInitializerListOp next steps Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant