You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, what is "not implemented" appears to be a IsEqual for array constructors. Line 550 in flang/include/flang/Lower/Support/Utils.h (line number correct at the time of writing).
The right solution here is not to add text to the printout (the only function in that file that isn't implemented yet). It is to implement a comparison for Array Constructors. I'm not doing this right now (I was just looking into this "between some other tickets", but I will add it to the list of "work needed for atomics" that we have internally. I just spent enough time to assess the general size of this task.
I did confirm that returning true works for this test-case - obviously, this is not a complete solution, so a more thorough comparison will be needed.
Anyone feeling like working on writing a IsEqual for Array Constructors, feel free to comment and take over this ticket.
Reproducible on Godbolt:
https://godbolt.org/z/rxd39r59G
Reproducer:
Stack dump:
It would be better if it was stated what feature is "not implemented".
The text was updated successfully, but these errors were encountered: