Skip to content
This repository has been archived by the owner on Oct 24, 2020. It is now read-only.

Throw clear error when metrics_options missing #67

Open
rpappalax opened this issue Apr 28, 2017 · 1 comment
Open

Throw clear error when metrics_options missing #67

rpappalax opened this issue Apr 28, 2017 · 1 comment

Comments

@rpappalax
Copy link
Contributor

LambdaFunctionFailed
{"error":"KeyError","cause":"{\"stackTrace\": [[\"/var/task/handler.py\", 18, \"ensure_metrics_available\", \"return runner.ensure_metrics_available()\"], [\"/var/task/ardere/step_functions.py\", 239, \"ensure_metrics_available\", \"self.ecs.create_metrics_service(self.event[\\\"metrics_options\\\"])\"], [\"/var/task/ardere/aws.py\", 359, \"create_metrics_service\", \"\\\"\\\"\\\" % (self.grafana_admin_user, self.grafana_admin_password) # noqa\"], [\"/var/task/ardere/aws.py\", 194, \"grafana_admin_user\", \"return self._plan[\\\"metrics_options\\\"][\\\"dashboard\\\"][\\\"admin_user\\\"]\"]], \"errorType\": \"KeyError\", \"errorMessage\": \"'dashboard'\"}"} 
@pjenvey
Copy link
Member

pjenvey commented Apr 28, 2017

We enable metrics when no options are specified, however the defaults don't include any dashboard entry, hence a KeyError here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants