Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying a BASIC program alerts constantly with "problematic byte 13" #107

Open
mattgodbolt opened this issue Nov 2, 2024 · 1 comment
Open
Assignees

Comments

@mattgodbolt
Copy link
Owner

I fixed an error where this.emulator.readmem wasn't defined. But...looks like there's code that alerts all the time:

                while (len--) {
                    let b = this.emulator.readmem(addr++);
                    if (b < 32 || (b >= 127 && b < 161)) {
                        if (b == 10 || b == 13) alert("problematic byte value " + b);
                        b += 0x100;
                    }
                    data += String.fromCodePoint(b);
                }

@8bitkick I'm not sure what this is supposed to do but copying any memory pretty much kills the browser with this (as it has a modal alert up)

@ojwb
Copy link
Contributor

ojwb commented Nov 5, 2024

Sadly @8bitkick broke my saving memory feature - I pointed this out in #96 nearly 2 years ago but I never got a response...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants