Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding "too long" lines should...not #18

Open
mattgodbolt opened this issue Nov 29, 2020 · 1 comment
Open

Expanding "too long" lines should...not #18

mattgodbolt opened this issue Nov 29, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@mattgodbolt
Copy link
Owner

Some lines are too long to expand. We should avoid doing so.

@mattgodbolt mattgodbolt added the bug Something isn't working label Nov 30, 2020
@ojwb
Copy link
Contributor

ojwb commented Sep 29, 2021

mattgodbolt/jsbeeb@8935c9a should have improved the situation here - I think the only problem cases now are where we insert spaces after expanded tokens (which is needed in some cases for re-tokenising to recognise certain tokens - see 37fbf18 where I implemented that).

Maybe a better way to solve the remaining part of this is for "shrink" to remove spaces where we know it is safe to? There's always potential to break programs which peek data within the program, but I think that can already happen with tokenised line numbers vs integer literal line numbers.

I might take a look, unless you think it's a bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants