You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a ton of shared code between different optimizer wrappers:
setting up the parameters
comm splitting and bcast after
creating the solution after
There are also tons of class attributes which are set by each optimizer without using the class structure properly. All these can be reorganized with significantly less code duplication.
Potential solution
Create a __call__ function in the parent class, which does the shared stuff:
This can call optimizer-specific functions which does the actual work (generating inputs, calling the optimizer, etc.)
In the init, properly set the class attributes.
The text was updated successfully, but these errors were encountered:
Description of feature
There is a ton of shared code between different optimizer wrappers:
There are also tons of class attributes which are set by each optimizer without using the class structure properly. All these can be reorganized with significantly less code duplication.
Potential solution
__call__
function in the parent class, which does the shared stuff:The text was updated successfully, but these errors were encountered: