-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[com.lge.launcher3] phonesky breaks recents screen #2699
Comments
v0.2.27 is very outdated, test with v0.3.6 instead. |
Huh, just checked again and it reads 0.3.6.244735. Not sure why I wrote 0.2.27 earlier. Nonetheless the issue persists. |
With "phonesky" do you mean microG Companion or the real Google Play Store? If it is microG Companion: Both microG Services and microG Companion must be version 0.3.6 or higher. |
microG companion
Mmm, no luck. Installing microG companion at 0.3.6.40226 still causes the issue. |
Try reset data of microG Companion and then if it happens again take a logcat and post it here please. |
Sure, here's the relevant portion of the logcat: More specifically, the crash is
When microG companion is uninstalled, there are no such E/AndroidRuntime crashes. My LGHome.apk is here: https://drive.google.com/file/d/1D1p2m34XldnLD0SFl4g4pe_STc-wHwx4/view?usp=drive_link I also decompiled and lightly annotated the addItem method: public void addItem(String itemToAdd) {
Launcher thisLauncher = this.mLauncher;
List launcherActivityList = null;
Context thisContext = null;
int var2;
int var3;
int var4;
ShortcutInfo var8;
LauncherActivityInfo var9;
LinearLayout.LayoutParams var10;
BubbleTextView var12;
if (thisLauncher != null) {
LauncherAppState.getInstance(thisLauncher).getIconCache();
launcherActivityList = LauncherAppsCompat.getInstance(this.mLauncher).getActivityList(itemToAdd, Process.myUserHandle());
if (itemToAdd.equals("com.android.contacts")) {
Iterator var11 = launcherActivityList.iterator();
while(true) {
var8 = thisContext;
if (!var11.hasNext()) {
break;
}
var9 = (LauncherActivityInfo)var11.next();
if (var9.getComponentName().flattenToShortString().contains("DialtactsActivity")) {
var8 = ShortcutInfo.fromActivityInfo(var9, this.mLauncher);
break;
}
}
} else {
// FIXME: launcherActivityList is an empty list here
var8 = ShortcutInfo.fromActivityInfo((LauncherActivityInfo)launcherActivityList.get(0), this.mLauncher);
}
if (var8 != null) {
var12 = (BubbleTextView)this.mLauncher.createShortcut(this, var8, 2131492918);
var8.usingLowResIcon = true;
var12.setTag(var8);
var12.verifyHighRes();
var12.setTextVisibility(false);
var4 = this.getResources().getDimensionPixelSize(2131166196);
this.mIconSize = var12.getIconSize();
var3 = this.mIconSize;
var2 = var4 * 2;
var10 = new LinearLayout.LayoutParams(var3 + var2, var3 + var2);
var12.setPadding(var4, var4, var4, var4);
var12.setLayoutParams(var10);
this.addView(var12);
}
} else {
thisContext = this.mContext;
if (thisContext != null) {
LauncherAppState.getInstance(thisContext).getIconCache();
List launcherActivityList2 = LauncherAppsCompat.getInstance(this.mContext).getActivityList(itemToAdd, Process.myUserHandle());
if (itemToAdd.equals("com.android.contacts")) {
Iterator var14 = launcherActivityList2.iterator();
while(true) {
var8 = launcherActivityList;
if (!var14.hasNext()) {
break;
}
var9 = (LauncherActivityInfo)var14.next();
if (var9.getComponentName().flattenToShortString().contains("DialtactsActivity")) {
var8 = ShortcutInfo.fromActivityInfo(var9, this.mContext);
break;
}
}
} else {
var8 = ShortcutInfo.fromActivityInfo((LauncherActivityInfo)launcherActivityList2.get(0), this.mContext);
}
if (var8 != null) {
var12 = (BubbleTextView)this.createShortcut(this.mContext, this, var8);
var8.usingLowResIcon = true;
var12.setTag(var8);
var12.verifyHighRes();
var12.setTextVisibility(false);
var4 = this.getResources().getDimensionPixelSize(2131166196);
var2 = var12.getIconSize();
var3 = var4 * 2;
var10 = new LinearLayout.LayoutParams(var2 + var3, var12.getIconSize() + var3);
var12.setPadding(var4, var4, var4, var4);
var12.setLayoutParams(var10);
this.addView(var12);
}
}
}
} so it's clear that the crash is happening when LGHome tries to |
Can you try if installing the -hw variant of com.android.vending solves this issue? https://github.com/microg/GmsCore/releases/download/v0.3.6.244735/com.android.vending-84022612-hw.apk |
Seems to work! Any idea why? |
Huawei doesn't allow to distribute apps through their store that don't have a launcher activity, so the -hw variant has a dummy launcher activity. So this confirms that your launcher requires that the |
Affected app
Name: Home
Package id: com.lge.launcher3
Describe the bug
When I install phonesky (fdroid), the next time I tap the square nav button, the recents screen will open, but each time after that will crash com.lge.launcher3.
To Reproduce
Steps to reproduce the behavior:
System
Android Version: 12
Custom ROM: stock
microG
microG Core version: 0.2.27.223616
microG Self-Check results: all ticked, except of course the phonesky one when it's uninstalled
Additional context
I tried switching to Lawnchair+QuickSwitch as my recents provider but that didn't work either. See LawnchairLauncher/lawnchair#5047 (comment) for logs of the launcher3 crash—I only just figured out it was phonesky-related.
The text was updated successfully, but these errors were encountered: