Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AD settings on workspace creation page should adhere to AUTO_WORKSPACE_APP_REGISTRATION and AUTO_WORKSPACE_GROUP_CREATION #2628

Open
marrobi opened this issue Sep 21, 2022 · 6 comments · May be fixed by #3407
Open

AD settings on workspace creation page should adhere to AUTO_WORKSPACE_APP_REGISTRATION and AUTO_WORKSPACE_GROUP_CREATION #2628

marrobi opened this issue Sep 21, 2022 · 6 comments · May be fixed by #3407
Assignees
@marrobi
Labels
bug Something isn't working story Stories are the smallest unit of work to be done for a project. storysize/M 1 day
Milestone
Release 0.19.0

Comments

@marrobi
Copy link
Member

marrobi commented Sep 21, 2022 •
edited
Loading

When deploying a workspace the user is prompted to choose authentication settings. As these are defined by AUTO_WORKSPACE_APP_REGISTRATION and AUTO_WORKSPACE_GROUP_CREATION they should not be user configurable as this can lead to mismatch with the app registration configuration and workspace deployment fails as per #3190

Notes:
At present this need this file https://github.com/microsoft/AzureTRE/blob/main/api_app/schemas/azuread.json to be edited. This means that the API app needs to be rebuilt. I suggest the values in this file are dynamically generated so they can be customised without rebuilding the API image.
@marrobi marrobi added feature story Stories are the smallest unit of work to be done for a project. and removed feature labels Sep 21, 2022
@marrobi
Copy link
Member Author

marrobi commented Sep 29, 2022

Or combine with #2112 and #2538

Import the appropriate file(s) based on the global setting.

@tamirkamara
Copy link
Collaborator

@marrobi should this still be open?

@tamirkamara tamirkamara changed the title Default workspace creation UI to auto_create and do not prompt the user. Default workspace creation UI to auto_create and do not prompt the user Jan 3, 2023
@marrobi marrobi changed the title Default workspace creation UI to auto_create and do not prompt the user Remove AD settings from workspace creation page and adhere to AUTO_WORKSPACE_APP_REGISTRATION and AUTO_WORKSPACE_GROUP_CREATION Feb 2, 2023
@marrobi
Copy link
Member Author

marrobi commented Feb 2, 2023 •
edited
Loading

@marrobi should this still be open?

I've updated the title and description to match the original intention now we have new ENV vars, and actually think its a bug, cost a few hours today.

@marrobi marrobi added this to the Backlog milestone Feb 2, 2023
@marrobi marrobi mentioned this issue Feb 2, 2023
Closed
@marrobi marrobi added the bug Something isn't working label Feb 3, 2023
@marrobi marrobi moved this to Up Next in Azure TRE - Engineering Feb 3, 2023
@marrobi marrobi removed this from the Backlog milestone Feb 3, 2023
@marrobi marrobi changed the title Remove AD settings from workspace creation page and adhere to AUTO_WORKSPACE_APP_REGISTRATION and AUTO_WORKSPACE_GROUP_CREATION AD settings on workspace creation page should adhere to AUTO_WORKSPACE_APP_REGISTRATION and AUTO_WORKSPACE_GROUP_CREATION Feb 3, 2023
@marrobi marrobi removed their assignment Feb 6, 2023
@marrobi
Copy link
Member Author

marrobi commented Feb 24, 2023

We discussed amending the error message (which isn't currently visible as per #2363 could be a way to mitigate).

@marrobi marrobi self-assigned this Apr 3, 2023
@marrobi marrobi moved this from Up Next to In Progress in Azure TRE - Engineering Apr 3, 2023
@marrobi marrobi linked a pull request Apr 3, 2023 that will close this issue
Draft
1 task
@marrobi
Copy link
Member Author

marrobi commented May 10, 2023

Another instance of this #3494

@marrobi marrobi moved this from In Progress to PR in Azure TRE - Engineering Jun 27, 2023
@marrobi marrobi added the blocked Cannot progress at present label Jul 4, 2023
@marrobi
Copy link
Member Author

marrobi commented Jul 11, 2023

Another instance here - #3608 (reply in thread)

@tim-p-allen tim-p-allen removed the blocked Cannot progress at present label May 9, 2024
@tim-p-allen tim-p-allen added this to the Release 0.19.0 milestone May 10, 2024
@PoojanumN PoojanumN assigned tim-p-allen and unassigned marrobi May 22, 2024
@tim-p-allen tim-p-allen added the storysize/M 1 day label May 23, 2024
@PoojanumN PoojanumN assigned marrobi and unassigned tim-p-allen Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marrobi marrobi

Labels
bug Something isn't working story Stories are the smallest unit of work to be done for a project. storysize/M 1 day
Projects
Azure TRE - Engineering
Status: In Progress
Milestone
Release 0.19.0
Development

Successfully merging a pull request may close this issue.

Remove AAD params from templates and configure in API. marrobi/AzureTRE
3 participants
@marrobi @tamirkamara @tim-p-allen