-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] test against R 4.2.2 #5621
Conversation
# https://github.com/kalibera/rchk/issues/22#issuecomment-656036156 | ||
exit $( | ||
cat ${RCHK_LOG_FILE} \ | ||
| grep -v "in function strptime_internal" \ | ||
| grep -v "in function RunGenCollect" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to address the following new error from rchk
on R 4.2.2.
ERROR: too many states (abstraction error?) in function RunGenCollect
full rchk log (click me)
Library name (usually package name): lightgbm
Initialization function: R_init_lightgbm
Functions: 41
Checked call to R_registerRoutines: 1
ERROR: too many states (abstraction error?) in function strptime_internal
ERROR: too many states (abstraction error?) in function RunGenCollect
Analyzed 40027 functions, traversed 105616 states.
Rchk version: 29e18222e1cfa67ba8e63bd3b22a25f78593c554
R version: 83396/R Under development (unstable) (2022-12-02 r83396)
LLVM version: 14.0.0
I think it's ok to skip it, based on kalibera/rchk#22 (comment), for the same reason we skip the warning about strptime_internal
.
RunGenCollect
is from R's internals, not LightGBM's code.
@@ -76,7 +76,7 @@ if [[ $OS_NAME == "macos" ]]; then | |||
brew install --cask basictex || exit -1 | |||
export PATH="/Library/TeX/texbin:$PATH" | |||
sudo tlmgr --verify-repo=none update --self || exit -1 | |||
sudo tlmgr --verify-repo=none install inconsolata helvetic || exit -1 | |||
sudo tlmgr --verify-repo=none install inconsolata helvetic rsfs || exit -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the following error on macOS jobs related to missing fonts used when creating the PDF version of the docs.
* checking PDF version of manual ... � � � � WARNING
LaTeX errors when creating PDF version.
This typically indicates Rd problems.
LaTeX errors found:
! Font U/rsfs/m/n/10=rsfs10 at 10.0pt not loadable: Metric (TFM) file not found
.
<to be read again>
relax
l.24 ...ghly-efficient-gradient-boosting-decision}
! Font U/rsfs/m/n/7=rsfs7 at 7.0pt not loadable: Metric (TFM) file not found.
<to be read again>
relax
l.24 ...ghly-efficient-gradient-boosting-decision}
\AsIs{>.
! Font U/rsfs/m/n/5=rsfs5 at 5.0pt not loadable: Metric (TFM) file not found.
<to be read again>
relax
l.24 ...ghly-efficient-gradient-boosting-decision}
\AsIs{>
Changed this to |
@jmoralez you are my hero with all these quick reviews, thank you so much!! |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Contributes to #3763.
R 4.2.2 was released in October 2022. Changelog: https://cran.r-project.org/bin/windows/base/old/4.2.2/NEWS.R-4.2.2.html.
This PR proposes upgrading from R 4.2.1 to R 4.2.1 in LightGBM's R 4.2.x CI jobs.
Notes for Reviewers
This will resolve an
R CMD check
warning I observed on #5563That can happen when binaries have been built by CRAN with a newer version of R than the one that you're using.