Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting relations and columns (discussion) #120

Open
ericmuijsvanoord opened this issue Feb 6, 2024 · 3 comments
Open

Quoting relations and columns (discussion) #120

ericmuijsvanoord opened this issue Feb 6, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ericmuijsvanoord
Copy link

ericmuijsvanoord commented Feb 6, 2024

By default relations and columns are quoted by double quotes " in dbt. What do you think about setting the quoting to [] which is more T-SQL like?

@ericmuijsvanoord ericmuijsvanoord changed the title Quoting columns (discussion) Quoting relations and columns (discussion) Feb 8, 2024
@prdpsvs
Copy link
Collaborator

prdpsvs commented Feb 27, 2024

@ericmuijsvanoord , quoting character in dbt is a single character. dbt cannot support [ and ] characters because it has different starting and ending characters. Let me take a look into this to see if there is way to support multiple opening/ending characters.

@prdpsvs prdpsvs added the enhancement New feature or request label Feb 27, 2024
@prdpsvs prdpsvs self-assigned this Feb 27, 2024
@prdpsvs prdpsvs added the wontfix This will not be worked on label Apr 11, 2024
@prdpsvs
Copy link
Collaborator

prdpsvs commented Apr 11, 2024

@ericmuijsvanoord , The double quotes standard is used in dbt-core and adapter implementation way too many places. Standardizing that would not be a small effort and I am putting this on back burner.

@prdpsvs prdpsvs closed this as completed Apr 11, 2024
@prdpsvs prdpsvs reopened this Apr 16, 2024
@prdpsvs prdpsvs removed the wontfix This will not be worked on label Apr 16, 2024
@dataders
Copy link
Collaborator

dataders commented May 2, 2024

also I want to tie-in an issue that I opened over 3 years ago
related: dbt-msft/dbt-sqlserver#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants