-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: missing docs - preventDismissOnResize is deprecated, usage of replacement is unclear #30431
Comments
Hello @jeffersoneagley , before assigning this issue to an appropriate team I need more information from you. Because it doesn't look like a bug, it's more like a feature or question. You wrote |
@ValentinaKozlova This isn't a code issue, it's just a gap in the documentation. I don't really want to go fishing through the type definitions for the function. |
This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes. |
keep open |
I created a PR to remove the deprecated warning from those props. We have no plans to remove them from v8, and it seems fine to have a simpler API for common use cases. But for the record, if you wanted to replicate
|
Library
React / v8 (@fluentui/react)
System Info
Are you reporting Accessibility issue?
None
Reproduction
https://developer.microsoft.com/en-us/fluentui#/controls/web/callout#ICalloutProps
Bug Description
Actual Behavior
I'm looking at the following doc:
https://developer.microsoft.com/en-us/fluentui#/controls/web/callout#ICalloutProps
preventDismissOnResize
is deprecated. The suggested replacement ispreventDismissOnEvent
. There's no actual explanation of how to replicate the behavior ofpreventDismissOnResize
withpreventDismissOnEvent
. I know it's probably easy, but it's unclear and a time-burner.Side note: there's also not a clear path to submit feedback on the docs themselves.
Logs
No response
Requested priority
Normal
Products/sites affected
https://developer.microsoft.com/en-us/fluentui#/controls/web/callout#ICalloutProps
Are you willing to submit a PR to fix?
no
Validations
The text was updated successfully, but these errors were encountered: