Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2024 Issue/PR Grooming - review, categorization, assignment #235576

Open
rebornix opened this issue Dec 8, 2024 · 5 comments
Open

2024 Issue/PR Grooming - review, categorization, assignment #235576

rebornix opened this issue Dec 8, 2024 · 5 comments
Assignees
@joaomoreno @rebornix @karthiknadig @kieferrm @alexdima @sbatten
Labels
plan-item VS Code - planned item for upcoming

Comments

@rebornix
Copy link
Member

rebornix commented Dec 8, 2024 •
edited by osortega
Loading

The number of issues that we receive every months across all our repositories is large enough so that despite our best efforts to triage and close issues we fall behind as soon as we carve out time for some focussed, uninterrupted development time. Now it's the time to focus on housekeeping and bring our issue database to a great shape. You can track our progress on https://joaomoreno.github.io/vscode-github-stats/.

Priorities for the December 2024 Housekeeping

  1. Bring our issue database back into great shape
  2. Reduce the number of open bugs by fixing them

Note: Don't distract yourself with fixing issues if your part of the issue database is not yet in great shape. Clearly, we'll use common sense, i.e. we'll make easy fixes on the fly if they take us a couple of minutes. We'll not make the fix if it takes us two hours. Also, refrain from engaging in debt reduction work until the issue database is organized and the number of open bugs is down.

Review Guidelines

In the first pass we review all issues across all our repositories. During review please make sure:

  • to close obsolete/fixed issues and mark duplicates as appropriate,
  • that each issue has a type label
  • that each issue is assigned to a feature area
  • that bugs you fix in December are assigned to the December milestone. Be conservative, see above.
  • to close out-of-scope feature requests assign the *out-of-scope label. There is no value in keeping issues open that don't have any realistic chance of being addressed.
  • close bugs as "won't fix" if there is a cost-benefit imbalance. It's not that we don't care about users who are affected by an issue but, for example, if the fix is so involved that we risk regressions for many, fixing is not a reasonable choice.

Otherwise the normal rules apply:

  • assign the important label to issues that
    • result in data loss
    • a breakage of extension
    • critical security, performance issues
    • UI issue that makes a feature unusable
  • issues that the community can take up should be labeled as help-wanted
  • if issues are suitable for beginners you can also add the good-first-issue label and add code pointers that help beginners to get started with a PR
  • feature requests that should be implemented as extensions should be labeled extensions-candidate and be closed

Tracking

Please make sure that you also housekeep in our satellite repositories.

Issues assigned to you

Issues assigned to feature areas but without owner

Other issues

  • ensure we don't have any issues assigned to people who are no longer on the team @rebornix
@rebornix rebornix added the plan-item VS Code - planned item for upcoming label Dec 8, 2024
@rebornix rebornix pinned this issue Dec 8, 2024
@aiday-mar
Copy link
Contributor

For the list Issues assigned to feature areas but without owner are we supposed to each mark the feature areas we are responsible for so that only the feature areas that belong to nobody are left unchecked?

@alexr00 alexr00 mentioned this issue Dec 9, 2024
Closed
@sahin52
Copy link

sahin52 commented Dec 9, 2024

Can you please update issue templates? Empty issues are causing a huge problem, at least 20% of tasks doesnt have enough information and hard/impossible to reproduce. Updating github template, Vscode Report Issue template, Vscode web report issue template might prevent these problematic tasks

@alexr00 alexr00 mentioned this issue Dec 10, 2024
Open
@MasterInQuestion
Copy link

    Those who do not learn from the history: inevitably retrace the same mistakes, again and again.
    Most future incidents are mere repetition of the old.
    Not seeing which eventually traps in the constant "reinventing the wheel" predicament.

    Alike: https://github.com/MasterInQuestion/talk/discussions/31

    子曰: "温故而知新".
+    Master said: "Reviewing old and recognize new".

@ChaseKnowlden ChaseKnowlden mentioned this issue Dec 12, 2024
Open
@joshspicer joshspicer mentioned this issue Dec 17, 2024
Merged
@iwangbowen
Copy link

It's a big project

@kieferrm kieferrm unpinned this issue Dec 19, 2024
@kieferrm kieferrm pinned this issue Dec 19, 2024
@MasterInQuestion
Copy link

MasterInQuestion commented Dec 21, 2024 •
edited
Loading

    Indeed big project.
    But inevitable; for even bigger projects.

    ----

    A valid current issue closed & locked:
    https://github.com/microsoft/vscode/issues/206902#issuecomment-1985097029
    (and I'm not inclined toward creating new duplicate)

@kieferrm kieferrm unpinned this issue Dec 23, 2024
@kieferrm kieferrm pinned this issue Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaomoreno joaomoreno

@rebornix rebornix

@karthiknadig karthiknadig

@kieferrm kieferrm

@alexdima alexdima

@sbatten sbatten

Labels
plan-item VS Code - planned item for upcoming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
12 participants
@joaomoreno @rebornix @legomushroom @karthiknadig @kieferrm @alexdima @sbatten @iwangbowen @sahin52 @aiday-mar @MasterInQuestion and others