Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node as npm script runner #234468

Open
xymopen opened this issue Nov 23, 2024 · 3 comments · May be fixed by #236967
Open

Add node as npm script runner #234468

xymopen opened this issue Nov 23, 2024 · 3 comments · May be fixed by #236967
Assignees
@connor4312
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors npm Issues with the built-in npm extension
Milestone
Backlog

Comments

@xymopen
Copy link

xymopen commented Nov 23, 2024

As Node.js 22 being promoted to LTS recently, node --run should be considered sable. Can we add it as a npm script runner?

https://nodejs.org/docs/latest-v22.x/api/cli.html#--run
@rebornix rebornix assigned connor4312 and unassigned roblourens Dec 16, 2024
@connor4312 connor4312 added feature-request Request for new features or functionality npm Issues with the built-in npm extension labels Dec 16, 2024
@connor4312 connor4312 added this to the Backlog milestone Dec 16, 2024
@connor4312 connor4312 added the good first issue Issues identified as good for first-time contributors label Dec 16, 2024
@connor4312
Copy link
Member

extension that handles this: https://github.com/microsoft/vscode/tree/main/extensions/npm

@xymopen
Copy link
Author

xymopen commented Dec 17, 2024

Thanks. I'll try to make a PR for it.

@xymopen
Copy link
Author

xymopen commented Dec 23, 2024

It seems that the createTask() is also used for installing dependencies which is not supported by node --run. I'm thinking about separating the dependencies installation and script runner and also a separated setting.

@xymopen xymopen linked a pull request Dec 26, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors npm Issues with the built-in npm extension
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add node as npm script runner xymopen/vscode
3 participants
@roblourens @connor4312 @xymopen