-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): リアルタイム更新時のノート取得にCDNキャッシュを併用できるように #15188
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: あわわわとーにゅ <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15188 +/- ##
===========================================
+ Coverage 39.96% 41.57% +1.61%
===========================================
Files 1563 1567 +4
Lines 197878 203973 +6095
Branches 3646 3685 +39
===========================================
+ Hits 79080 84806 +5726
- Misses 118193 118560 +367
- Partials 605 607 +2 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -431,6 +431,9 @@
"enableReactionsBuffering": {
"type": "boolean"
},
+ "enableStreamNotesCdnCache": {
+ "type": "boolean"
+ },
"notesPerOneAd": {
"type": "number"
},
@@ -664,6 +667,7 @@
"perUserHomeTimelineCacheMax",
"perUserListTimelineCacheMax",
"enableReactionsBuffering",
+ "enableStreamNotesCdnCache",
"notesPerOneAd",
"backgroundImageUrl",
"deeplAuthKey",
@@ -14333,6 +14337,9 @@
"enableReactionsBuffering": {
"type": "boolean"
},
+ "enableStreamNotesCdnCache": {
+ "type": "boolean"
+ },
"notesPerOneAd": {
"type": "integer"
},
@@ -82429,6 +82436,9 @@
"enableUrlPreview": {
"type": "boolean"
},
+ "enableStreamNotesCdnCache": {
+ "type": "boolean"
+ },
"backgroundImageUrl": {
"type": [
"string",
@@ -82529,6 +82539,7 @@
"translatorAvailable",
"mediaProxy",
"enableUrlPreview",
+ "enableStreamNotesCdnCache",
"backgroundImageUrl",
"impressumUrl",
"logoImageUrl", |
具体的な方法を思いついてないけど、型の問題どうにかしたい気持ちがある |
どの部分かしら? |
とりあえずmisskey-js側に型ガード関数を置いてtestのアサーションを撲滅した |
minimizeがfalse/未指定のときにはnote eventはNoteを返してほしい。古いコードの型を壊しちゃうのと、シンプルに対応する気がない人がわざわざasしないといけないのは避けたい |
もの自体はそうなってるはず(型をあわせるのは難しそうなのでガード関数にした) |
これは型の上でそうしたいってこと |
What
かいてあるとおり(デフォルトオフ、設定画面には「べータ」の文字も入れてある)
Why
Fix #15187
Additional info (optional)
connection.cacheNote
はCDNの使用の有無に関係なく実行すべきでは?(今はioの実装そのままにしてある)Checklist