Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to detect feed type on https://www.derstandard.at/rss/web #166

Open
torlenor opened this issue Dec 28, 2020 · 3 comments
Open

Failed to detect feed type on https://www.derstandard.at/rss/web #166

torlenor opened this issue Dec 28, 2020 · 3 comments

Comments

@torlenor
Copy link

gofeed cannot detect the feed type on feed
https://www.derstandard.at/rss/web

Expected behavior

Return a valid parsed feed, without error.

Actual behavior

Parsing the feed results in "Failed to detect feed type"

Steps to reproduce the behavior

Try parsing the feed

fp := gofeed.NewParser()
feed, err := fp.ParseURL("https://www.derstandard.at/rss/web")
@milochristiansen
Copy link

I have this exact issue. Loads of RSS 2.0 feeds are not being detected. Oddly, an old version of my RSS notifier built with some unknown older version of this library seems to work fine. Investigating.

@milochristiansen
Copy link

Reverting to v1.0.0-beta2 fixes my issue. I'm not wasting my time trying to figure out if that is the last version that works or not, I just know that it is a version that works.

@nkanaev
Copy link
Contributor

nkanaev commented Apr 4, 2021

the issue has been fixed in d5ae839 and is on master, but hasn't been released by semver (cc: @mmcdole v1.1.1 maybe?).

that said, the safest approach would be to not assume the input to be utf-8 all the time, and pass a reader that's capable of handling bom encodings & various charsets instead (for ex.: golang.org/x/net/hmtl/charset.NewReader & dimchansky/utfbom)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants