Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authors don't seem to be parsed correctly #178

Closed
akeemphilbert opened this issue Jun 1, 2021 · 4 comments
Closed

Authors don't seem to be parsed correctly #178

akeemphilbert opened this issue Jun 1, 2021 · 4 comments

Comments

@akeemphilbert
Copy link

akeemphilbert commented Jun 1, 2021

Expected behavior

Rss feed with <author>[email protected]</author> or

<atom:author>
      <atom:name>John Doe</atom:name>
    </atom:author>

Doesn't get the authors parsed.

<itunes:author>John Doe</itunes:author> does work
Sample Feed

<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">
  <channel>
    <title>Akeem Philbert&#39;s Blog</title>
    <link>https://ak33m.com/</link>
    <description>Recent content on Akeem Philbert&#39;s Blog</description>
    <generator>Hugo -- gohugo.io</generator>
    <language>en-us</language>
    <author>[email protected]</author>
    <lastBuildDate>Sat, 27 Mar 2021 17:05:53 -0400</lastBuildDate><atom:link href="https://ak33m.com/index.xml" rel="self" type="application/rss+xml" />
    <item>
      <title>It&#39;s Over Magento!</title>
      <link>https://ak33m.com/posts/its-over-magento/</link>
      <pubDate>Sat, 27 Mar 2021 17:05:53 -0400</pubDate>
      
      <guid>https://ak33m.com/posts/its-over-magento/</guid>
      <description>So I&amp;rsquo;ve always had a hate-hate relationship with Magento (there never was love). Ours was a convenient relationship; I needed something to run an online bookstore we wanted to start, and all the other solutions we looked at didn&amp;rsquo;t fit the bill. We wanted to accept payments in Trinidad and Tobago dollars, something you don&amp;rsquo;t get easier with hosted solutions. We also wanted something that had broad support and a variety of templates.</description>
    </item>
  </channel>
</rss>
@Necoro
Copy link
Contributor

Necoro commented Jun 1, 2021

That's because <author> is, according to spec, part of <item> and not of <channel>.

@akeemphilbert
Copy link
Author

You're right thanks. Though for atom it is on the main (I tried it with the namespace as per the example I gave above and no dice)

@Necoro
Copy link
Contributor

Necoro commented Jun 1, 2021

@akeemphilbert: For mixing RSS and atom, you can try my branch at https://github.com/Necoro/gofeed/tree/fix_151 (cf. issue #151 / PR #153 ). That handles atom:author in RSS as well.

@akeemphilbert
Copy link
Author

Cool yeah I saw this and wondered if it was going to get merged in. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants