Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[popups] Require Portal part #1222

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[popups] Require Portal part #1222

wants to merge 3 commits into from

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Dec 24, 2024 •
edited
Loading

Closes #1215

  • Each component has its own separate Portal component, rather than a shared one now, as the context cannot be shared.
  • Removed keepMounted prop on Positioner and Popup since it's specified by Portal in all scenarios.

@atomiks atomiks added component: select This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: alert dialog This is the name of the generic UI component, not the React module! component: tooltip This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module! component: popover The React component. component: preview card The React component. labels Dec 24, 2024
@mui-bot
Copy link

mui-bot commented Dec 24, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-1222--base-ui.netlify.app/

Generated by 🚫 dangerJS against 2d41b5e

@atomiks atomiks force-pushed the fix/portal-existence branch 3 times, most recently from 53db81e to a326ad8 Compare December 24, 2024 06:23
@atomiks
[popups] Require Portal part
7a73a79 
Remove keepMounted on portal child parts

Remove unused imports

Remove keepMounted prop in tests
@atomiks atomiks force-pushed the fix/portal-existence branch from a326ad8 to 7a73a79 Compare December 24, 2024 06:31
@atomiks atomiks marked this pull request as ready for review December 24, 2024 06:39
@atomiks atomiks mentioned this pull request Dec 27, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: alert dialog This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: popover The React component. component: preview card The React component. component: select This is the name of the generic UI component, not the React module! component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Portal part cannot be omitted safely when nesting popups
2 participants
@atomiks @mui-bot