Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NA introduced in cl_name when plotting bar dendrogram figure #20

Open
HDash opened this issue Dec 16, 2024 · 0 comments · May be fixed by #19
Open

NA introduced in cl_name when plotting bar dendrogram figure #20

HDash opened this issue Dec 16, 2024 · 0 comments · May be fixed by #19
Assignees
@HDash @bschilder
Labels
bug Something isn't working

Comments

@HDash
Copy link
Contributor

HDash commented Dec 16, 2024

For the function example, "type II pneumocyte" is missing in ddata$labels$label, which causes results[[celltype_col]] to contain NA values. As a result, one entire column of the dendrogram figure gets labelled "NA" in the final figure.

MSTExplorer/R/plot_bar_dendro.R

Lines 81 to 86 in 84b749c

ddata <- ontology_to_ggdendro(ont=cl,
terms=as.character(unique(results$cl_id)))
#### Make celltypes an ordered factor based on the clustering #####
results[[celltype_col]] <- factor(results[[celltype_col]],
levels=unique(ddata$labels$label),
ordered = TRUE)

Refer to the output below (notice the last x-axis value, NA):
function_output
@HDash HDash added the bug Something isn't working label Dec 16, 2024
@HDash HDash linked a pull request Dec 16, 2024 that will close this issue
Tests / Check fixes #19
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HDash HDash

@bschilder bschilder

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests / Check fixes neurogenomics/MSTExplorer
2 participants
@HDash @bschilder