Confirm Deletion by Password-Entry

[xbluemonkx]

Hi,

everywhere in Nextcloud you have to confirm critical changes by entering your password. Even uncritical changes (e.g. adding a user to a group).

I think it would be good to have a password confirmation too if you want to delete a group folder.

[joshtrichards]

This will be easier after #3140 since we can then just use the existing vue library: https://github.com/nextcloud-libraries/nextcloud-password-confirmation

groupfolders/src/settings/App.tsx

Lines 106 to 118 in 44c1040

	deleteFolder(folder: Folder) {
	OC.dialogs.confirm(
	t('groupfolders', 'Are you sure you want to delete "{folderName}" and all files inside? This operation cannot be undone', { folderName: folder.mount_point }),
	t('groupfolders', 'Delete "{folderName}"?', { folderName: folder.mount_point }),
	confirmed => {
	if (confirmed) {
	this.setState({ folders: this.state.folders.filter(item => item.id !== folder.id) })
	this.api.deleteFolder(folder.id)
	}
	},
	true,
	)
	}

Even uncritical changes (e.g. adding a user to a group).

Well adding a user to the admin group would give them special privileges. ;-)

[provokateurin]

Fixed in all recent releases.