Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide properly typed selectors example for CustomSerializer #4301

Open
1 of 2 tasks
moniuch opened this issue Apr 16, 2024 · 0 comments
Open
1 of 2 tasks

Provide properly typed selectors example for CustomSerializer #4301

moniuch opened this issue Apr 16, 2024 · 0 comments

Comments

@moniuch
Copy link
Contributor

moniuch commented Apr 16, 2024

Information

When following the instructions for creating a custom serializer, there is no explanation how to provide custom selectors for the returned properties { url, params, queryParams } (as the default ones provided by getRouterSelectors cease to work). It's maybe not that hard to write code that works, the intimidating part for a lot of users might be the proper TS typing.

A good accompanying selectors example for this serializer would be gold. Thank you.

Documentation page

https://ngrx.io/guide/router-store/configuration#custom-router-state-serializer

I would be willing to submit a PR to fix this issue

  • Yes
  • No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant