Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWC update does not trigger CI #101

Closed
marco-ippolito opened this issue Oct 30, 2024 · 3 comments · Fixed by nodejs/admin#933
Closed

SWC update does not trigger CI #101

marco-ippolito opened this issue Oct 30, 2024 · 3 comments · Fixed by nodejs/admin#933
Labels
good first issue Good for newcomers

Comments

@marco-ippolito
Copy link
Member

The PR is created by the swc update action. The CI does not start

@marco-ippolito marco-ippolito added the good first issue Good for newcomers label Oct 30, 2024
@legendecas
Copy link
Member

FWIW, a @nodejs-github-bot's token can be requested at https://github.com/nodejs/admin/blob/main/request-an-access-token.md

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs.
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/triggering-a-workflow#triggering-a-workflow-from-a-workflow

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Dec 26, 2024

I updated with the new token but it still fails:
https://github.com/nodejs/amaro/actions/runs/12506701416/job/34892036019

Change: 9ceb649

cc @mhdawson

It appears the token does not have the right permissions

@legendecas
Copy link
Member

I granted @nodejs-github-bot write access to this repo. Restarted the job and it works now: #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants