-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement URLPattern #40844
Comments
Thanks for the heads up — obviously our feature request template is not very well-suited for these kinds of issues, but given that the specification for Mainly being a volunteer-run organization, we have no real priorities (whatever gets done, gets done); that being said, this issue cannot be represented by one of the N values in that system… I would say to perhaps set it as |
@nodejs/url what do you think? |
So I opened the original issue for support in Deno, I opened it on Deno as Deno tends to support considerably more cutting edge things. Having said this, having it Node would be particularly valuable for libraries that are currently using And having a common pattern syntax for things like routing would just generally be nice to have, so that libraries don't have a bunch of different microsyntaxes for essentially the same thing. |
@targos ... I'm +1 on an having an implementation in core. I have some concerns about the performance as spec'd but having an implementation makes sense. |
There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment. For more information on how the project manages feature requests, please consult the feature request management document. |
There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment. For more information on how the project manages feature requests, please consult the feature request management document. |
+1 |
Let's open this issue. I'm +1 on having this on core. |
+1 |
+1 |
1 similar comment
+1 |
+1 |
1 similar comment
+1 |
Stop posting +1Hello everyone, I've noticed that several people are posting "+1" on this issue thread. While I understand that this is meant to indicate support for the issue, it's actually causing a lot of unnecessary notifications for everyone who is subscribed to this thread. Additionally, posting "+1" does not add any meaningful contribution to the conversation and only make scrolling through the page more annoying in order to find the most meaningful comments. Instead of posting a comment with "+1", I suggest that you simply use the "subscribe" button at the top of the issue thread to receive updates. Additionally, if you want to show support, you can use the "thumbs up" reaction on the original post. This will help keep the thread clean and reduce notifications for everyone. I appreciate your interest in this issue, but please keep in mind that posting "+1" repeatedly can become frustrating and annoying to those who are subscribed. By using the subscribe button and reactions, we can keep the conversation focused and productive. I don't want to have to unsubscribe to this topic if more ppl are going to post +1 Thank you for your understanding and cooperation. |
I've locked and limited the issue to collaborators. |
This comment was marked as outdated.
This comment was marked as outdated.
I'm almost done with the implementation. I'll try to open a pull-request to Node.js by the end of this year: ada-url/ada#785 |
UrlPattern promotes a bad, non-performant pattern for server-side code, unless a I don't think we should be adding this without a |
Don't know if you have heard of this new URLPattern
Deno shipped it, and browser supports it, would be a cool util to have globally avalible to pear up with web standards and for usage in express routing for instance
The text was updated successfully, but these errors were encountered: