Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement URLPattern #40844

Open
jimmywarting opened this issue Nov 17, 2021 · 19 comments
Open

implement URLPattern #40844

jimmywarting opened this issue Nov 17, 2021 · 19 comments
Labels
discuss Issues opened for discussions and feedbacks. feature request Issues that request new features to be added to Node.js. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@jimmywarting
Copy link

Don't know if you have heard of this new URLPattern
Deno shipped it, and browser supports it, would be a cool util to have globally avalible to pear up with web standards and for usage in express routing for instance

@DerekNonGeneric DerekNonGeneric added discuss Issues opened for discussions and feedbacks. feature request Issues that request new features to be added to Node.js. labels Nov 18, 2021
@DerekNonGeneric
Copy link
Contributor

DerekNonGeneric commented Nov 18, 2021

Thanks for the heads up — obviously our feature request template is not very well-suited for these kinds of issues, but given that the specification for URLPattern is still in draft, I imagine that we would be setting the Webcompat Priority value of this to either ? or revisit if we were to use a triage system similar to what Mozilla uses for their WebCompat Tracking and Triage workflow.

Mainly being a volunteer-run organization, we have no real priorities (whatever gets done, gets done); that being said, this issue cannot be represented by one of the N values in that system…

I would say to perhaps set it as revisit and come back later once spec becomes a recommendation.

@targos targos changed the title impl URLPattern implement URLPattern Nov 18, 2021
@targos targos added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Nov 18, 2021
@targos
Copy link
Member

targos commented Nov 21, 2021

Spec is at https://github.com/WICG/urlpattern
WPT: https://github.com/web-platform-tests/wpt/tree/master/urlpattern

@targos
Copy link
Member

targos commented Nov 21, 2021

@nodejs/url what do you think?

@Jamesernator
Copy link

Jamesernator commented Nov 23, 2021

Deno shipped it, and browser supports it, would be a cool util to have globally avalible to pear up with web standards and for usage in express routing for instance

So I opened the original issue for support in Deno, I opened it on Deno as Deno tends to support considerably more cutting edge things.

Having said this, having it Node would be particularly valuable for libraries that are currently using path-to-regexp for patterns. The syntax is essentially the same (aside from a few bug fixes to work with URLs more generally), so libraries that are currently using path-to-regexp could use the builtin URLPattern instead, allowing them to remove a external dependency.

And having a common pattern syntax for things like routing would just generally be nice to have, so that libraries don't have a bunch of different microsyntaxes for essentially the same thing.

@jasnell
Copy link
Member

jasnell commented Nov 23, 2021

@targos ... I'm +1 on an having an implementation in core. I have some concerns about the performance as spec'd but having an implementation makes sense.

@targos targos moved this to Awaiting triage in Node.js feature requests Jan 16, 2022
@targos targos moved this from Pending Triage to In Progress in Node.js feature requests Feb 25, 2022
@Mesteery Mesteery linked a pull request Feb 25, 2022 that will close this issue
@github-actions
Copy link
Contributor

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Aug 25, 2022
@github-actions
Copy link
Contributor

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@targos targos moved this from In Progress to Pending Triage in Node.js feature requests Oct 22, 2022
@dionsaur84
Copy link

+1

@anonrig
Copy link
Member

anonrig commented Feb 19, 2023

Let's open this issue. I'm +1 on having this on core.

@anonrig anonrig reopened this Feb 19, 2023
@github-actions github-actions bot removed the stale label Feb 19, 2023
@AugustinMauroy
Copy link
Member

+1
It's can be good to create an simple routing system with nodejs built-in module.

@jdhrivas
Copy link

jdhrivas commented Mar 4, 2023

+1

1 similar comment
@lucianmot
Copy link

+1

@anonrig anonrig moved this from Pending Triage to Todo in Node.js feature requests Mar 22, 2023
@mharis
Copy link

mharis commented Mar 30, 2023

+1

1 similar comment
@bj-nostra
Copy link

+1

@jimmywarting
Copy link
Author

jimmywarting commented Apr 4, 2023

Stop posting +1

Hello everyone,

I've noticed that several people are posting "+1" on this issue thread. While I understand that this is meant to indicate support for the issue, it's actually causing a lot of unnecessary notifications for everyone who is subscribed to this thread. Additionally, posting "+1" does not add any meaningful contribution to the conversation and only make scrolling through the page more annoying in order to find the most meaningful comments.

Instead of posting a comment with "+1", I suggest that you simply use the "subscribe" button at the top of the issue thread to receive updates. Additionally, if you want to show support, you can use the "thumbs up" reaction on the original post. This will help keep the thread clean and reduce notifications for everyone.

I appreciate your interest in this issue, but please keep in mind that posting "+1" repeatedly can become frustrating and annoying to those who are subscribed. By using the subscribe button and reactions, we can keep the conversation focused and productive.

I don't want to have to unsubscribe to this topic if more ppl are going to post +1

Thank you for your understanding and cooperation.

@nodejs nodejs locked as too heated and limited conversation to collaborators Apr 4, 2023
@anonrig
Copy link
Member

anonrig commented Apr 4, 2023

I've locked and limited the issue to collaborators.

@anonrig

This comment was marked as outdated.

@anonrig
Copy link
Member

anonrig commented Dec 12, 2024

I'm almost done with the implementation. I'll try to open a pull-request to Node.js by the end of this year: ada-url/ada#785

@mcollina
Copy link
Member

UrlPattern promotes a bad, non-performant pattern for server-side code, unless a UrlPatternList (or Trie) is added as well. This is discussed in whatwg/urlpattern#30 (comment) and whatwg/urlpattern#166.

I don't think we should be adding this without a UrlPatternList counterpart.

@nodejs nodejs unlocked this conversation Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues opened for discussions and feedbacks. feature request Issues that request new features to be added to Node.js. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.