Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for paths or filenames with spaces #29

Open
dominik-hadl opened this issue Mar 29, 2020 · 1 comment · May be fixed by #42
Open

Support for paths or filenames with spaces #29

dominik-hadl opened this issue Mar 29, 2020 · 1 comment · May be fixed by #42

Comments

@dominik-hadl
Copy link

When using the DIFF_BASE to only lint files changed in a PR, file paths containing spaces will be ignored. I've tried playing around with it myself but wasn't able to get bash to escape/pass the strings to swift lint correctly.

Ideally, both of the cases below should be supported:

Sources/Supporting Files/Test.swift
Sources/My File.swift
@petrpalata petrpalata mentioned this issue Dec 3, 2020
Closed
@ayoy
Copy link

ayoy commented May 12, 2022

Submitted a PR with a fix that works for me: #42

@ayoy ayoy linked a pull request May 12, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ayoy @dominik-hadl