Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing resources #21

Open
15 of 16 tasks
Ninigi opened this issue Mar 20, 2018 · 9 comments
Open
15 of 16 tasks

Add missing resources #21

Ninigi opened this issue Mar 20, 2018 · 9 comments
Labels
good first issue Easy to fix issue, does not need a lot of experience to be able to contribute help wanted

Comments

@Ninigi
Copy link
Collaborator

Ninigi commented Mar 20, 2018

There are still some resources missing according to this list.

Since most of them follow the same pattern, I think this is a good first issue.

EDIT: Here is a list of resources I think we are missing. This might be incomplete or accidentally list a resource we already have under a different name, so before diving in please make sure I did not make a mistake first 🙇

  • AbandonedCheckout (just realized this is the same as Checkout
  • Fulfillment ❗
  • FulfillmentEvent
  • FulfillmentService
  • GiftCard (Shopify PLUS only!) 💤
  • InventoryItem
  • InventoryLevel
  • Location ❗
  • MarketingEvent
  • Multipass (SHOPIFY PLUS only!) 💤
  • OrderRisk
  • Page
  • Policy
  • ProductListing
  • Refund
  • Report
@Ninigi Ninigi added help wanted good first issue Easy to fix issue, does not need a lot of experience to be able to contribute labels Mar 20, 2018
@humancopy
Copy link
Contributor

Any other resources missing that you need help with?

@Ninigi
Copy link
Collaborator Author

Ninigi commented Apr 27, 2018

@humancopy quite a few iirc... From the top of my head I can think about Fulfillment, because I was really surprised that one wasn't already in there. I am planing to put some work into missing resources next week (golden week, yay 🏌️ ), I guess my first step will be to compile a list of missing resources.

@Ninigi
Copy link
Collaborator Author

Ninigi commented May 2, 2018

@humancopy I made a list 🥇

@humancopy
Copy link
Contributor

Oh wow I see you went through most of them already! Well done! 😄

So the Shopify Plus ones you don't want to implement for now?

@Ninigi
Copy link
Collaborator Author

Ninigi commented May 9, 2018

@humancopy I don't have a Shopify gold store, so I wouldn't be able to actually test it nor would I be using it, so I'd like to leave it to someone else to actually implement those :)

@antonioparisi
Copy link

is there anything missing from adding the create method on the checkout resource?

@Ninigi
Copy link
Collaborator Author

Ninigi commented Oct 5, 2018

@antonioparisi not that I am aware of. Why? Is something missing?

Edit: sorry I am on mobile, I can’t check right now. If the create function is missing, could you maybe add it and create a PR?

@antonioparisi
Copy link

@Ninigi I think the checkout resource is missing the create.
https://github.com/nsweeting/shopify/blob/master/lib/shopify/resources/checkout.ex#L9

as you can see from the Shopify API docs:
https://help.shopify.com/en/api/reference/sales_channels/checkout#create

@antonioparisi
Copy link

@Ninigi also the update one is missing for the checkout resource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easy to fix issue, does not need a lot of experience to be able to contribute help wanted
Projects
None yet
Development

No branches or pull requests

3 participants