Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since 4.08 merlin no longer likes toplevel directives #1023

Open
dbuenzli opened this issue Sep 19, 2019 · 2 comments · May be fixed by #1134
Open

Since 4.08 merlin no longer likes toplevel directives #1023

dbuenzli opened this issue Sep 19, 2019 · 2 comments · May be fixed by #1134
Labels
Kind/Bug

Comments

@dbuenzli
Copy link

< 4.08 merlin didn't complain about #use and #require directives in ocaml scripts. Since 4.08 it seems it does ("Syntax error").

I didn't test 4.09.
@hnrgrgr hnrgrgr linked a pull request Apr 23, 2020 that will close this issue
Open
@sangwoo-joh
Copy link

I still have this issue with OCaml 4.12.0 + merlin 4.3.1-412.

@mndrix
Copy link
Contributor

mndrix commented Jan 28, 2022

I ran into this today with OCaml 4.13.1 and merlin 4.4-413. For example,

#!/usr/bin/env ocaml

#load "unix.cma"

let () = print_endline (Unix.getenv "HOME")

Merlin reports a syntax error on line 3. ocaml and ocamlformat handle the example with a smile; even GitHub's syntax highlighting does ok :-)

@SleepyMug SleepyMug mentioned this issue Nov 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Kind/Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RFC: don't fail on directives when the file starts with #! hnrgrgr/merlin
4 participants
@mndrix @trefis @dbuenzli @sangwoo-joh