Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to contribute towers? #224

Open
nukeop opened this issue Aug 13, 2018 · 1 comment
Open

How to contribute towers? #224

nukeop opened this issue Aug 13, 2018 · 1 comment
Labels
area: towers Related to towers type: question A question

Comments

@nukeop
Copy link

nukeop commented Aug 13, 2018

More of a question than an issue.

I assume I can't just for warriorjs, add my tower to it, and submit a pull request. I scoured npmjs.com for warriorjs modules, but I only found the official ones. If I were to create my own tower module, should I publish it on npm as a standalone package, or should I add it to this repo in a pull request after a review process? Will warriorjs find my module automatically on npm, or will people have to download it manually and paste it?

@olistic olistic added area: towers Related to towers type: question A question labels Aug 13, 2018
@olistic
Copy link
Owner

olistic commented Aug 13, 2018

Let me try to answer all your questions separately:

If I were to create my own tower module, should I publish it on npm as a standalone package?

Yes, you should publish it to npm following the guidelines here and here.

should I add it to this repo in a pull request after a review process?

This is something you can do in addition to publishing it to npm. I don't guarantee your tower will be included in the game out of the box, but it's certainly a possibility. Let me also mention that I'm about to release an online version of the game (same core, so the same towers can work in both the CLI and the online version) and I'm open to requests for including new towers into the online version as well. Check it out here.

Will warriorjs find my module automatically on npm, or will people have to download it manually and paste it?

Neither. warriorjs will find towers automatically, but they have to be installed via npm first. Just installed, no extra step required, and the CLI will take care of the rest (finding it and making it available in the game).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: towers Related to towers type: question A question
Projects
None yet
Development

No branches or pull requests

2 participants