-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working on iOS 12 #693
Comments
Me also facing the same issues. Need solution for this at earliest. |
Sadly this has been an issue from the beginning. It also keeps hypothes.is from loading properly on an Annotator.js site or vice versa. What are your current use cases where you need to load it twice? |
@BigBlueHat |
@amlanroy-ust that's likely a different problem. You shouldn't need two instances of annotator.js loaded on a page to deal with two separate annotations. Once it's in place, it should be usable for multiple highlights/annotations. That said, I'd not focus too heavily on Annotator.js as it's developers have moved on to other things. Most notably, the Apache Annotator project aims to provide the library bits for creating similar user experiences in browsers. Depending on how far along you are down the implementation road, you may want to consider the libraries their plus your own UX code. |
@BigBlueHat |
@amlanroy-ust ah. This is a different problem then what @marialaraa had posted about, I believe. If possible, I'd recommend posting an example page that others can load on iOS 12 devices to test. However, I'd also recommend not investing in anything Annotator.js based for the future as it's a stalled project which is actively being replace by Apache Annotator. @marialaraa please let me know if your situation is any of the ones described above. Thanks! |
I have tested on iOS 12 and it doesn't annotate more than one time I need to refresh if I want to annotate multiple time just like @amlanroy-ust and @marialaraa have mentioned above. I have tested on iOS 11 and it working perfectly fine. Please resolve this issue. |
It is certainly stopped working from iOS 12 onwards. Our users can't do multiple annotate without refreshing the page. Could this be assigned to someone as soon as possible? |
@danielignatius if you fix the issue, I might be able to review it and merge it, but no one is actively maintaining this project. |
The same as @danielignatius. |
I have found a temporary fix to iOS 12 issue. This fix would allow the users to annotate more than once without refreshing the page. If you can guys take it from here and improve it that would be great. Comment out on hide return _this.element.find(":focus").blur(); inside of Then I applied setTimeout for textarea blur and focus for few functions in annotator-full.js
|
@melissajeon |
Hi @amlanroy-ust , sorry I just remember that I unminified the annotator.full.min.js(version 1.2.10) for my self. I reckon you can unminify annotator-full.min.js or annotator.min.js and find those functions then insert setTimeout snippet at correct places. download link: https://github.com/openannotation/annotator/releases/tag/v1.2.10 |
@melissajeon |
Hi @amlanroy-ust based on #458 |
@melissajeon |
On this operating system if the user add one annotator then he is unable to add a new one. The only option is to refresh the site and then he would be able add a new one.
Any idea of how to solve this problem?
The text was updated successfully, but these errors were encountered: