Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default ingress annotation from helm chart so that ingressClassName is settable in wrapped chart #1100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove default ingress annotation from helm chart so that ingressClassName is settable in wrapped chart #1100

wants to merge 1 commit into from

Conversation

rlaveycal
Copy link

Description

Remove the default ingress annotation that defaults to nginx. ingressClassName is the correct way to set the ingress.

Why is this needed?

Fixes #1000

When the chart is wrapped inside another it is not possible to unset the ingress annotation (see helm/helm/issues/9027). This means that if ingress.ingressClassName is set the deployment fails due to the annotation also being present.

Who is this for?

We are StructureFlow.

How Has This Been Tested?

I've successfully deployed my local change to a local cluster with the ingress enabled and ingressClassName: nginx

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek
Copy link

derek bot commented Apr 27, 2023

Thank you for your contribution. It seems that one or more of your commits have a "Signed-off-by" statement with an anonymous email address. The Developer Certificate of Origin (DCO) requires all commits to be signed off by genuine, contactable individuals. Please see our contributing guide.

### :bulb: Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "[email protected]"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

@rlaveycal rlaveycal force-pushed the remove_ingress_annotation branch from 55e451d to eb0f4bb Compare April 27, 2023 12:52
@derek derek bot removed the no-dco label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clash between ingress.class annotation and ingressClassName attribute in latest charts
1 participant
@rlaveycal