Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when generating types: some attribute names contain spaces #14

Open
brigon-clever-age opened this issue Sep 7, 2023 · 1 comment
Open

Error when generating types: some attribute names contain spaces #14

brigon-clever-age opened this issue Sep 7, 2023 · 1 comment

Comments

@brigon-clever-age
Copy link

Hi there !

When generating types using sfcc-dts-setup or sfcc-dts-updateattrs, the attrs.d.ts contains attributes with spaces in names:

image
brigon-clever-age pushed a commit to brigon-clever-age/sfcc-dts that referenced this issue Sep 7, 2023
@brigon-lacoste
fix: openmindlab#14 | Add quotes around custom types containing space…
a3344d1 
… in their names. Add possibility to specify the meta directory as a commande line option with --metaPath=./site-meta/meta/
@brigon-clever-age brigon-clever-age mentioned this issue Sep 7, 2023
Open
brigon-clever-age pushed a commit to brigon-clever-age/sfcc-dts that referenced this issue Sep 7, 2023
@brigon-lacoste
fix: openmindlab#14 | Add quotes around custom types containing space…
596a84d 
… in their names. Add possibility to specify the meta directory as a commande line option with --metaPath ./site-meta/meta/ --cartridgePath ./cartridges/
@brigon-clever-age
Copy link
Author

I created a PR to fix the issue.
The PR also adds command line arguments to allow specifying meta path and cartridge path (to use sfcc-dts-setup or sfcc-dts-updateattrs from a CI for example)

npm run sfcc-dts-setup -- --cartridgePath ./cartridges/ --metaPath ./site-meta/meta/

brigon-clever-age pushed a commit to brigon-clever-age/sfcc-dts that referenced this issue Sep 7, 2023
@brigon-lacoste
fix: openmindlab#14 | Add quotes around custom types containing space…
4e2a8ed 
… in their names. Add possibility to specify the meta directory as a commande line option with --metaPath ./site-meta/meta/ --cartridgePath ./cartridges/
@brigon-clever-age brigon-clever-age mentioned this issue Sep 7, 2023
Open
brigon-clever-age pushed a commit to brigon-clever-age/sfcc-dts that referenced this issue Sep 8, 2023
@brigon-lacoste
fix: openmindlab#14 | Add quotes around custom types containing space…
afdc131 
… in their names. Add possibility to specify the meta directory as a commande line option with --metaPath ./site-meta/meta/ --cartridgePath ./cartridges/ and --attrsOutputPath @types/dw/
brigon-clever-age pushed a commit to brigon-clever-age/sfcc-dts that referenced this issue Sep 11, 2023
@brigon-lacoste
fix: openmindlab#14 | Add quotes around custom types containing space…
b03acff 
… in their names. Add possibility to specify the meta directory as a commande line option with --metaPath ./site-meta/meta/ --cartridgePath ./cartridges/ and --attrsOutputPath @types/dw/

Remove \r from descriptions to keep only \n to fix a display issue on windows
brigon-clever-age pushed a commit to brigon-clever-age/sfcc-dts that referenced this issue Sep 13, 2023
@brigon-lacoste
fix: openmindlab#14 | Add quotes around custom types containing space…
b8a2873 
… in their names. Add possibility to specify the meta directory as a commande line option with --metaPath ./site-meta/meta/ --cartridgePath ./cartridges/ and --attrsOutputPath @types/dw/

Remove \r from descriptions to keep only \n to fix a display issue on windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brigon-clever-age