Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Add basic git based code checks #663

Open
Wovchena opened this issue Jul 22, 2024 · 21 comments
Open

[Good First Issue]: Add basic git based code checks #663

Wovchena opened this issue Jul 22, 2024 · 21 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@Wovchena
Copy link
Collaborator

Context

As a first step to improving GenAI code style, basic checks defined in the project's pre-commit configuration should be run.

What needs to be done?

  1. Run 3 checks from https://github.com/openvinotoolkit/model_api/blob/66384b0b747dee0fb3e37c6466115b7e60da3a10/.github/workflows/test_precommit.yml#L12-L16. Python (e.g., black --check .) and C++ specific checks are out of scope.
  2. Fix detected issues. Some files are expected to fail. For example ™ is an expected non ASCII symbol in root README.md. Exclude such files from testing.
  3. Add a new job within the GitHub Actions workflow to https://github.com/openvinotoolkit/openvino.genai/blob/master/.github/workflows/causal_lm_cpp.yml to run these three checks.
  4. Submit a pull request (PR).

Example Pull Request

#315

Resources

Contact points

@Wovchena

@Wovchena Wovchena added the good first issue Good for newcomers label Jul 22, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Jul 22, 2024
@rk119
Copy link

rk119 commented Jul 25, 2024

.take

Copy link

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@rk119 rk119 removed their assignment Jul 31, 2024
@LitZeus
Copy link

LitZeus commented Sep 27, 2024

.take

Copy link

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@Wovchena
Copy link
Collaborator Author

@LitZeus, are you still working on this?

@LitZeus
Copy link

LitZeus commented Oct 11, 2024

no, I am not getting the right solution...
@Wovchena

@Wovchena
Copy link
Collaborator Author

Can you describe the problem?

@Wovchena
Copy link
Collaborator Author

Feel free to take the issue again if you work on it.

@mlukasze mlukasze moved this from In Review to Contributors Needed in Good first issues Nov 6, 2024
@mlukasze mlukasze moved this from Contributors Needed to In Review in Good first issues Nov 6, 2024
@mlukasze mlukasze moved this from In Review to Contributors Needed in Good first issues Nov 6, 2024
@rishik-ashili
Copy link

.take

Copy link

github-actions bot commented Nov 9, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

rishik-ashili added a commit to rishik-ashili/openvino.genai that referenced this issue Nov 9, 2024
@Wovchena
Copy link
Collaborator Author

@rishik-ashili, do you still work on this?

@rishik-ashili
Copy link

rishik-ashili commented Nov 13, 2024 via email

rishik-ashili added a commit to rishik-ashili/openvino.genai that referenced this issue Nov 13, 2024
@Wovchena
Copy link
Collaborator Author

@rishik-ashili, do you still work on this?

@Cyber-Var
Copy link

.take

Copy link

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@Cyber-Var
Copy link

Sure, thank you!

@FReakYdiVi
Copy link

.take

Copy link

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

@FReakYdiVi
Copy link

@Cyber-Var do you still working on this issue?

@Cyber-Var
Copy link

Yes, I am

@Cyber-Var
Copy link

I've created a pull-request.
#1453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Contributors Needed
Development

Successfully merging a pull request may close this issue.

6 participants