Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: New approach of updating translation #11

Open
belldandyxtq opened this issue May 31, 2021 · 2 comments
Open

Proposal: New approach of updating translation #11

belldandyxtq opened this issue May 31, 2021 · 2 comments

Comments

@belldandyxtq
Copy link
Collaborator

Background and Motivations

  1. Too many autogenerated changes (10k+), difficult to find translation update to review among them
  2. We may want to break the whole update into several PRs for parallel translation and review, but we may loose track of which file need to be translated.
  3. We want to prevent showing users the WIP version, while we have only one branch (master) and the website shows the latest master.

Proposal:

  1. Create a WIP branch from master with the name of the new version (e.g. branch-2.7), and all the temporary PRs will be created against this branch.
  2. Create a PR for all the autogenerated files; We only quickly check if there are any weird stuff included or not.
  3. Create a issue/list of files include translation update (with check box)
  4. Create PRs for each file/several files
  5. After all the translations PRs are merged, create a PR from the WIP to master

What do you think

@chenghuzi
Copy link
Collaborator

Agreed. Now the pace of optuna development has slowed down, we will have more time to work on different parts while still keeping track of the current version. Currently we've finished the translation of v2.7 (but not the auto-generated parts). So maybe we can add a tag and then Readthedoc could generate a version-specific doc for us.

@chenghuzi
Copy link
Collaborator

chenghuzi commented Jul 20, 2021

API Reference translation progress:

  • optuna
  • optuna.cli
  • optuna.distributions
  • optuna.exceptions
  • optuna.importance
  • optuna.integration
    • AllenNLP
    • BoTorch
  • optuna.logging
  • optuna.multi_objective
  • optuna.pruners
  • optuna.samplers
  • optuna.storages
  • optuna.structs
  • optuna.study
  • optuna.trial
  • optuna.visualization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants