Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KeyError by adding check for _convert_dates #60539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix KeyError by adding check for _convert_dates #60539

wants to merge 1 commit into from
+1 −1

Conversation

Uvi-12
Copy link
Contributor

@Uvi-12 Uvi-12 commented Dec 11, 2024

Closes #60536

This PR adds a check to prevent a KeyError when renaming columns by ensuring the original column name exists in the _convert_dates dictionary before updating it.

rhshadrach
rhshadrach requested changes Dec 27, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Whenever changing behavior, please add tests.

@rhshadrach rhshadrach added Bug IO Stata read_stata, to_stata labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Bug IO Stata read_stata, to_stata
Projects
None yet
Milestone
No milestone
2 participants
@Uvi-12 @rhshadrach