feat(server): add SubscriptionSink::connection_id
#1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
approved these changes
Aug 9, 2023
lexnv
reviewed
Aug 10, 2023
| @@ -322,6 +322,11 @@ impl SubscriptionSink { | |||
| self.method | |||
| } | |||
|
|
|||
| /// Get the connection ID. | |||
| pub fn connection_id(&self) -> ConnectionId { | |||
There was a problem hiding this comment.
Amazing!
Different topic: Would it also be possible to identify the client connected by this ConnectionID? (paritytech/substrate#14734)
There was a problem hiding this comment.
Yes that should work but the connection IDs may be reused once the connection is dropped and the counter wraps.
I guess that could handled when the subscription is dropped then just remove it from a HashMap or something
lexnv
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1163, added to provide uniform APIs