Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking of external deps in root manifest #36

Open
Morganamilo opened this issue Jul 15, 2024 · 0 comments
Open

Tracking of external deps in root manifest #36

Morganamilo opened this issue Jul 15, 2024 · 0 comments

Comments

@Morganamilo
Copy link
Collaborator

When an external dependency is bumped in the root manifest file, parity publish has no way to see this. The PR author must correctly declare all packages that the dep change effects.

If they are not declared, then the effected packages won't be marked for release. This is a big issue when the external dependency is visible in our public API.

This happened during the 1.14 release. One package using an external dep never got marked for release while another did. When publishing, eventually we got to a package depending on both. This caused a failure due to two incompatible versions of a library being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant