Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Config to GenesisConfig in construct_runtime #159

Closed
juangirini opened this issue Jun 26, 2023 · 2 comments
Closed

Rename Config to GenesisConfig in construct_runtime #159

juangirini opened this issue Jun 26, 2023 · 2 comments
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@juangirini
Copy link
Contributor

The keyword Config in construct_runtime should actually be GenesisConfig as it is currently at the risk of being confused with trait Config
@juangirini
Copy link
Contributor Author

This task is on hold until the new contruct_runtime syntax is defined here

@juangirini juangirini mentioned this issue Aug 24, 2023
Closed
@kianenigma kianenigma mentioned this issue Jul 21, 2023
Merged
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed T1-runtime labels Aug 25, 2023
@kianenigma
Copy link
Contributor

We now always refer to this as GenesisConfig afaik, should be closed.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME May 29, 2024
claravanstaden added a commit to claravanstaden/polkadot-sdk that referenced this issue Sep 19, 2024
@claravanstaden
Free finalized Ethereum updates (paritytech#159)
c7cbd99 
* free finalized updates

* update comment

* fix check

* fixes

* tests

* fixes

* fmt

* finishing touches

* comments

* adds missing impl

* adds test

* fixes

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juangirini @kianenigma @the-right-joyce