Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation of CRV2 to frame_support::runtime #4622

Closed
kianenigma opened this issue May 29, 2024 · 1 comment · Fixed by #4769
Closed

Improve documentation of CRV2 to frame_support::runtime #4622

kianenigma opened this issue May 29, 2024 · 1 comment · Fixed by #4769
Assignees
@gupnik
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@kianenigma
Copy link
Contributor

  • make it not be ignore
  • Explain DisableCall and DisableUnsigned more explicitly?
  • Provide link that this is the new version of frame_support::construct_runtime
  • Provide an explanation about the differences between the two, other than pallet ordering (eg. missing features).

Question: @gupnik Is it an intentional choice that you can only disable these two pallet parts, but not any of the other ones? why only these two where chosen?
@kianenigma kianenigma added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label May 29, 2024
@gupnik
Copy link
Contributor

gupnik commented May 29, 2024

Question: @gupnik Is it an intentional choice that you can only disable these two pallet parts, but not any of the other ones? why only these two where chosen?

This follows from @bkchr's comment here: #232 (comment)

@gupnik gupnik mentioned this issue Jun 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 25, 2024
@gupnik @bkchr
Use real rust type for pallet alias in runtime macro (#4769)
2f3a1bf 
Fixes #4723. Also,
closes #4622

As stated in the linked issue, this PR adds the ability to use a real
rust type for pallet alias in the new `runtime` macro:
```rust
#[runtime::pallet_index(0)]
pub type System = frame_system::Pallet<Runtime>;
```

Please note that the current syntax still continues to be supported.

CC: @shawntabrizi @kianenigma

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@gupnik @bkchr @TarekkMA
Use real rust type for pallet alias in runtime macro (paritytech#4769)
0bf8e0b 
Fixes paritytech#4723. Also,
closes paritytech#4622

As stated in the linked issue, this PR adds the ability to use a real
rust type for pallet alias in the new `runtime` macro:
```rust
#[runtime::pallet_index(0)]
pub type System = frame_system::Pallet<Runtime>;
```

Please note that the current syntax still continues to be supported.

CC: @shawntabrizi @kianenigma

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this issue Dec 27, 2024
@gupnik @bkchr
Use real rust type for pallet alias in runtime macro (paritytech#4769)
c0dbeac 
Fixes paritytech#4723. Also,
closes paritytech#4622

As stated in the linked issue, this PR adds the ability to use a real
rust type for pallet alias in the new `runtime` macro:
```rust
#[runtime::pallet_index(0)]
pub type System = frame_system::Pallet<Runtime>;
```

Please note that the current syntax still continues to be supported.

CC: @shawntabrizi @kianenigma

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gupnik gupnik

Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use real rust type for pallet alias in runtime macro paritytech/polkadot-sdk
2 participants
@kianenigma @gupnik